Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENDOC-566 7.1 Edits for loose threads #579

Merged
merged 2 commits into from
Sep 27, 2022
Merged

ENDOC-566 7.1 Edits for loose threads #579

merged 2 commits into from
Sep 27, 2022

Conversation

jyunmitch
Copy link
Collaborator

No description provided.


::: tip
See the [Plugin Environment Variables](../../tutorials/devops/plugin-environment-variables.md) tutorial to setup environment variables, either inline or based on Kubernetes Secrets.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set up

@@ -12,7 +12,7 @@ The docker-based approach is an improvement of the previous Entando Bundle struc

* There is a single bundle descriptor, `entando.json`, initialized and managed by the [ent bundle CLI](../getting-started/ent-bundle.md).
* Microservices and micro frontends can be built independently, each with their own folders.
* The `platform` directory is dedicated to platform specific components such as fragments, pages, and static resources.
* The `platform` directory is dedicated to platform specific components such as fragments, pages, and static resources. For more information on component types and descriptors, see the [Bundle Component Details ](bundle-component-details.md) page.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra space between "Details" and "]"

@@ -10,7 +10,7 @@ In addition, this document describes the series of `ent ecr` commands that manag

## Entando 7.1 Bundle Development

Beginning with Entando 7.1, the `ent bundle` command and its convenience methods introduce a streamlined process to govern the structure, files and management of Entando bundles. The bundle development lifecycle consists of 6 stages, each corresponding to a subcommand:
Beginning with Entando 7.1, the `ent bundle` module introduces a streamlined process to govern the files, structure, and management of Entando bundles. The bundle development lifecycle consists of 6 stages, each corresponding to a subcommand:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ent bundle cli tool (per discussion)

structure is the broadest term in that list and encompasses files, so the list should lead with it

Copy link
Collaborator Author

@jyunmitch jyunmitch Sep 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that ascending or descending is fine. In this case, because I wanted to end with the management, I picked ascending. The thinking was that management is bigger than structure since it controls it.

@Lyd1aCla1r3 Lyd1aCla1r3 self-requested a review September 27, 2022 17:25
@jyunmitch jyunmitch merged commit 6261b1d into main Sep 27, 2022
@jyunmitch jyunmitch deleted the ENDOC-566 branch September 27, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants