ENDOC-580 Add notes re ms/mfe stack options, refine component gen ove… #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rview, fix syncNext cmd
Lyd1aCla1r3
reviewed
Oct 18, 2022
| - The Entando blueprint includes scripts and tools to automatically generate a bundle ready for deployment to the ECR. The bundle will include your microservice, generated microfrontends, and any microfrontends that you have created manually under the `ui` folder | ||
| - The generated Spring Boot microservice can be built and deployed to a Docker registry using the provided maven Jib plugin | ||
| - Generated bundles can be pushed to a Git repository of the user's choice | ||
| - The Entando Blueprint generates code compatible with the docker-based bundle project structure introduced in Entando 7.1. The bundle project will include a microservice, entity-level microfrontends, as well as other components you have added manually to the project. |
There was a problem hiding this comment.
...a microservice and entity-level micro frontends as well as other components that have been added manually
| - The generated Spring Boot microservice can be built and deployed to a Docker registry using the provided maven Jib plugin | ||
| - Generated bundles can be pushed to a Git repository of the user's choice | ||
| - The Entando Blueprint generates code compatible with the docker-based bundle project structure introduced in Entando 7.1. The bundle project will include a microservice, entity-level microfrontends, as well as other components you have added manually to the project. | ||
| - The generated Spring Boot microservice can be built and deployed to a Docker registry using the provided build structure |
There was a problem hiding this comment.
this reads like the build structure performs build and deploy... maybe rephrase to clarify how the build structure enables build/deploy
There was a problem hiding this comment.
Or drop the build structure phrase...
|
|
||
| 3. Deploy bundles to the [Local Hub](../compose/local-hub-overview.md) | ||
| - Once your Docker images are pushed to your registry and your bundle is available in Git you can generate an Entando bundle descriptor and push the bundles to the ECR | ||
| - The bundles can be versioned and updated using tags in the Git repository | ||
| - Once your Docker images are pushed to your registry you can deploy the bundle to the Local Hub in an Entando Application |
There was a problem hiding this comment.
minor, but take the emphasis off of "you" to make instructions generalized and direct: "Once the Docker images are pushed to a registry, the bundle can be deploy to the Local Hub of an Entando Application"
| - The Entando blueprint includes scripts and tools to automatically generate a bundle ready for deployment to the ECR. The bundle will include your microservice, generated microfrontends, and any microfrontends that you have created manually under the `ui` folder | ||
| - The generated Spring Boot microservice can be built and deployed to a Docker registry using the provided maven Jib plugin | ||
| - Generated bundles can be pushed to a Git repository of the user's choice | ||
| - The Entando Blueprint generates code compatible with the docker-based bundle project structure introduced in Entando 7.1. The bundle project will include a microservice, entity-level microfrontends, as well as other components you have added manually to the project. |
There was a problem hiding this comment.
above comments apply to lines 33-38
Lyd1aCla1r3
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rview, fix syncNext cmd