Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENDOC-588 7.1 update bundle filtering #599

Merged
merged 2 commits into from
Oct 24, 2022
Merged

ENDOC-588 7.1 update bundle filtering #599

merged 2 commits into from
Oct 24, 2022

Conversation

Lyd1aCla1r3
Copy link
Contributor

No description provided.


![App Builder bundle filtering](./img/app-builder-bundle-component-filters.png)
To filter a bundle by component, its custom resource on the Entando Cluster must contain appropriate labels. Valid labels are: widget, plugin, fragment, pageTemplate, contentType and contentTemplate. To correctly define a label in a k8s resource requires both a key and value, but Entando uses only the key when filtering. Although the value is arbitrary, we recommend a setting of `"true"` for clarity and simplicity.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k8s >> K8s

since K8s requires both key and value, are the last two sentences saying you can use anything for value, including true or what?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

entando doesn't evaluate value but an entry is required by kubernetes and "true" is recommended


The corresponding custom-resource file on Kubernetes is similar to this:
The corresponding custom resource file on Kubernetes contains content similar to the following:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is minor but should this be "on Kubernetes" or "in kubernetes"? Does a CR file live/act in or on Kubernetes, this always kind of sits odd with me in different contexts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it's "on"... kubernetes runs things on a cluster of hosts... i also think the concept of layering applies, where things are on layers, not in them. pretty sure "in kubernetes" refers to conceptual architecture and "on kubernetes" refers to implementation

@Lyd1aCla1r3 Lyd1aCla1r3 merged commit 661b6a8 into main Oct 24, 2022
@nshaw nshaw deleted the ENDOC-588 branch May 23, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants