Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENDOC-608 add keycloak prereq #624

Merged
merged 2 commits into from
Nov 15, 2022
Merged

ENDOC-608 add keycloak prereq #624

merged 2 commits into from
Nov 15, 2022

Conversation

jyunmitch
Copy link
Collaborator

No description provided.

@@ -24,6 +24,7 @@ This tutorial covers:
* A working instance of Entando running on Kubernetes. See [Getting Started](../../docs/getting-started/) for more information or [install Entando on any Kubernetes provider](../#operations).
* Use the Entando CLI command `ent check-env develop` to verify all dependencies.
* A Jira Service Management account.
* A [Keycloak server](https://www.keycloak.org/docs/15.0/server_admin/#_email) configured with the your SMTP server settings to enable email verification for users.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: "the your"

"for users" is unnecessary and confusing if verification is enabled for the user email only; "for the user" is clear (but unnecessary) while "for users" implies a wider audience as much as the general function of the configuration

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

second item, it's the second case

Copy link
Contributor

@Lyd1aCla1r3 Lyd1aCla1r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple things

@jyunmitch jyunmitch merged commit 6f606a9 into main Nov 15, 2022
@jyunmitch jyunmitch deleted the ENDOC-608 branch November 15, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants