Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENDOC-618 fix architecture page - language + updates #631

Merged
merged 10 commits into from
Nov 29, 2022
Merged

Conversation

Lyd1aCla1r3
Copy link
Contributor

first pass

@Lyd1aCla1r3 Lyd1aCla1r3 marked this pull request as ready for review November 27, 2022 20:03
An Entando Application is an assembly of out-of-the-box and/or custom built components running on the
Platform. Components can be widgets, micro frontends, microservices, page templates, WCMS content or WCMS content types.
An Entando Application is an assembly of out-of-the-box and/or custom-built components running on the
Entando Platform. Entando components can be widgets, micro frontends, microservices, page templates, WCMS content or WCMS content types.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be a good idea to refer to Glossary here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure... the glossary doesn't have much to add and components aren't specialized in any way

Platform. With the ability to add Single Sign On capabilities across multiple domains, it connects service
providers with identity providers.
### Entando Identity Management
[Entando Identity Management](../consume/identity-management.md) is Entando's [Keycloak](https://www.keycloak.org/)-based user management and authentication system. It applies Single Sign On capabilities across multiple domains to connect service providers with identity providers.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be Entando Identity Management System, same in the glossary, that's the official name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a discrepancy here. it's referred to differently in different places. this terminology was just approved in the dev site glossary. happy to change it, but we need to be consistent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, the title of the corresponding page on the dev site is "entando identity management - keycloak"

### How Ingresses are used in an Entando Cluster

When deploying a cluster, ingresses are generated for the resources that require exposure to the outside world. The Entando Operator and custom resource controllers create the ingresses and set the correct routes and certificates.
An ingress is a Kubernetes resource that exposes HTTP and HTTPS paths from outside an Entando Cluster to services within it. Rules defined on the ingress resource control traffic routing.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rules defined on the ingress resource control traffic routing<< confusing sentence, hard to tell which is the verb, resource or control.

The original sentence reads clearer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will reword

@Lyd1aCla1r3 Lyd1aCla1r3 merged commit f6ac454 into main Nov 29, 2022
@nshaw nshaw deleted the ENDOC-618 branch May 23, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants