ENDOC-666: Add the meta tags for SEO using frontmatter section #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nshaw
suggested changes
Mar 21, 2023
There was a problem hiding this comment.
Hey, @avdev4j
- Please follow standard git practices. All commits should start with a ticket id as should the PR itself. This allows connecting the code changes to the requirements.
- I think that should be true even for blog posts (which this is not) unless @jyunmitch @Lyd1aCla1r3 have another idea.
- Did these changes work for you? I ran this in prod mode (yarn docs:build then serve per the README) and I do not see any of the og tags.
avdev4j
changed the title
… based on existing frontmatter properties
…roperty is not present in the Frontmatter section
avdev4j
force-pushed
the
add-meta-tags-in-frontmatter
branch
from
e26d8c6 to
1f1605f
Compare
|
@nshaw |
|
Closing in favor of #769 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.