Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endoc 806 standard demo #834

Merged
merged 3 commits into from
Jun 23, 2024
Merged

Endoc 806 standard demo #834

merged 3 commits into from
Jun 23, 2024

Conversation

nshaw
Copy link
Contributor

@nshaw nshaw commented Jun 14, 2024

No description provided.

@nshaw nshaw requested a review from jyunmitch June 14, 2024 15:58
Copy link
Collaborator

@jyunmitch jyunmitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes requested.

@@ -91,18 +86,16 @@ Install the Standard Banking Demo by integrating the Entando Cloud Hub into your
4. **`Install` each bundle:**

::: warning
**Order of installation is important.** The `standard-demo-content-bundle` must be installed last, as it relies on MFEs from the other bundles to set up each page. To uninstall the Banking demo, the `standard-demo-content-bundle` must be uninstalled first to resolve dependencies before other bundles can be be removed.
**Order of installation is important.** The `sd-content-bundle` must be installed last, as it relies on MFEs from the other bundles to set up each page. To uninstall the Banking demo, the `sd-content-bundle` bundle must be uninstalled first to resolve dependencies before other bundles can be be removed.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order of installation is important. sd-content-bundle must be installed last, as it relies on MFEs from the other bundles to set up each page. To uninstall the Banking demo, sd-content-bundle must be uninstalled first to resolve dependencies before other bundles can be be removed.

@@ -47,41 +47,36 @@ Install the Standard Banking Demo by integrating the Entando Cloud Hub into your
4. **From the Hub Catalog, `Deploy` and `Install` each of the four Standard Banking Demo bundles:**

::: warning
**The order of installation is important.** The `standard-demo-content-bundle` must be installed last, as it relies on MFEs from the other bundles to set up each page. To uninstall the Banking demo, the `standard-demo-content-bundle` must be uninstalled first to resolve dependencies before other bundles can be be removed.
**The order of installation is important.** The `sd-content-bundle` must be installed last, as it relies on MFEs from the other bundles to set up each page. To uninstall the Banking demo, the `sd-content-bundle` must be uninstalled first to resolve dependencies before other bundles can be be removed.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order of installation is important. sd-content-bundle must be installed last, as it relies on MFEs from the other bundles to set up each page. To uninstall the Banking demo, sd-content-bundle must be uninstalled first to resolve dependencies before other bundles can be be removed.

Never noticed, MFE is used here without first noting the the initialism above, at the first mention of micro frontends.

Can't comment on lines 10 & 11 above, but should add the initialisms there.

@@ -91,18 +86,16 @@ Install the Standard Banking Demo by integrating the Entando Cloud Hub into your
4. **`Install` each bundle:**

::: warning
**Order of installation is important.** The `standard-demo-content-bundle` must be installed last, as it relies on MFEs from the other bundles to set up each page. To uninstall the Banking demo, the `standard-demo-content-bundle` must be uninstalled first to resolve dependencies before other bundles can be be removed.
**Order of installation is important.** The `sd-content-bundle` must be installed last, as it relies on MFEs from the other bundles to set up each page. To uninstall the Banking demo, the `sd-content-bundle` bundle must be uninstalled first to resolve dependencies before other bundles can be be removed.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order of installation is important. sd-content-bundle must be installed last, as it relies on MFEs from the other bundles to set up each page. To uninstall the Banking demo, sd-content-bundle must be uninstalled first to resolve dependencies before other bundles can be be removed.

@@ -47,41 +47,36 @@ Install the Standard Banking Demo by integrating the Entando Cloud Hub into your
4. **From the Hub Catalog, `Deploy` and `Install` each of the four Standard Banking Demo bundles:**

::: warning
**The order of installation is important.** The `standard-demo-content-bundle` must be installed last, as it relies on MFEs from the other bundles to set up each page. To uninstall the Banking demo, the `standard-demo-content-bundle` must be uninstalled first to resolve dependencies before other bundles can be be removed.
**The order of installation is important.** The `sd-content-bundle` must be installed last, as it relies on MFEs from the other bundles to set up each page. To uninstall the Banking demo, the `sd-content-bundle` must be uninstalled first to resolve dependencies before other bundles can be be removed.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order of installation is important. sd-content-bundle must be installed last, as it relies on MFEs from the other bundles to set up each page. To uninstall the Banking demo, sd-content-bundle must be uninstalled first to resolve dependencies before other bundles can be be removed.

Never noticed, MFE is used here without first noting the the initialism above, at the first mention of micro frontends.

Can't comment on lines 10 & 11 above, but should add the initialisms there.

@nshaw nshaw merged commit c6c2716 into main Jun 23, 2024
1 check passed
@nshaw nshaw deleted the ENDOC-806-standard-demo branch June 23, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants