removes deprecated Revision::selectFields #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Personally I'm not worried about maintaining support for older MW versions. 1.31 is the current LTS, so supporting that should be sufficient. Things like Meza exist to make it easy for people to stay on latests MW versions. This change is fully tested and good to go? |
|
Yes it's tested, I'm ready for this to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes deprecated class warning I receive when working on 1.31 or later. I think this class doesn't exist before 1.31 so I'm not sure how we want to handle older support.
Ref: https://doc.wikimedia.org/mediawiki-core/master/php/classMediaWiki_1_1Revision_1_1RevisionStore.html#a892c273781fb32e235c0ad526d1a1999
When merged this will closes #78