Improve WatchAnalytics Styling

[krisfield]

• Makes CSS configurable colors/thresholds configurable
• Uses Mediawiki utility colors
• Cleans up README page since content is on MediaWiki.org

Issues

1. Closes cssColorClasses should be configurable #55
2. Closes Make color schemes match between Page Scores and Pending Reviews #46
3. Closes README doesn't have up to date info #21

[jamesmontalvo3]

All looks good except for some reason the first few pages in PendingReviews have now color. See DKMS.

[krisfield]

This is ready to be merged once you've completed a final review

[jamesmontalvo3]

I tried to go plaid by adding the following to settings:

$egWatchAnalyticsWatchQualityColors = [
	"21" => "plaid",
	"5" => "excellent",
	"1.5" => "okay"
];

Without that change one page's scores look like:

With that change above they look the same. If I make this change:

$egWatchAnalyticsWatchQualityColors = [
	21 => "plaid",
	5 => "excellent",
	1.5 => "okay"
];

then I get:

Changing 21 => "plaid" to 10 => "plaid" still no change.

Show me plaid!

[jamesmontalvo3]

If I modify extension.json to say "10" : "plaid" instead of "50" : "plaid" then I get glorious plaid:

[jamesmontalvo3]

I made this change to extension.json to make it respect my changes to LocalSettings.php:

                "WatchAnalyticsWatchQualityColors": {
                        "50" : "plaid",
                        "5" : "excellent",
-                       "1.5" : "okay"
+                       "1.5" : "okay",
+                       "_merge_strategy": "array_plus"
                },
                "WatchAnalyticsReviewStatusColors": {
                        "5" : "excellent",

Ref: https://www.mediawiki.org/wiki/Manual:Extension.json/Schema#Merge_strategies

Basically with extension registration (i.e. extension.json) you have to tell it how you want array globals to be handled. Do you want them to be overwritten, merged, etc. I'm not sure array_plus is the perfect solution, but it may be the best available option. I don't recall why the arrays are written in the form 50 => "plaid" versus "plaid" => 50, but that may be better.

[krisfield]

I made this change to extension.json to make it respect my changes to LocalSettings.php:

                "WatchAnalyticsWatchQualityColors": {
                        "50" : "plaid",
                        "5" : "excellent",
-                       "1.5" : "okay"
+                       "1.5" : "okay",
+                       "_merge_strategy": "array_plus"
                },
                "WatchAnalyticsReviewStatusColors": {
                        "5" : "excellent",

Ref: https://www.mediawiki.org/wiki/Manual:Extension.json/Schema#Merge_strategies

Basically with extension registration (i.e. extension.json) you have to tell it how you want array globals to be handled. Do you want them to be overwritten, merged, etc. I'm not sure array_plus is the perfect solution, but it may be the best available option. I don't recall why the arrays are written in the form 50 => "plaid" versus "plaid" => 50, but that may be better.

Thanks for the catch. I added the "array_plus" handling. As far as having numbered keys vs strings I think the current layout makes the most sense. Having the strings as keys seems weird to me.

[jamesmontalvo3]

Have you tested different configurations in LocalSettings.php to verify things are working as expected?

[krisfield]

Yes, that's how i tested the change