Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MediaWiki CodeSniffer for code style checks #88

Merged
merged 6 commits into from
Nov 28, 2018

Conversation

jamesmontalvo3
Copy link
Contributor

Use PHP CodeSniffer [1] with MediaWiki's standards [2] to check style. At present this will fail, but follow-on pull request(s) will fix the style issues. Additionally this PR does some other composer.json cleanup, including removing the ability to install WatchAnalytics with Composer. Composer is now only used to install dev dependencies (code sniffer for now, other testing packages later).

[1] https://github.com/squizlabs/PHP_CodeSniffer
[2] https://packagist.org/packages/mediawiki/mediawiki-codesniffer

@jamesmontalvo3 jamesmontalvo3 merged commit 3ae1e8d into master Nov 28, 2018
@jamesmontalvo3 jamesmontalvo3 deleted the composer-cleanup branch November 28, 2018 16:50
@jamesmontalvo3 jamesmontalvo3 restored the composer-cleanup branch November 28, 2018 16:50
@jamesmontalvo3 jamesmontalvo3 deleted the composer-cleanup branch November 29, 2018 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant