Approved revs #98
Merged
Approved revs #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Analytics update to most recent
krisfield
commented
Feb 11, 2019
krisfield
commented
Feb 11, 2019
jamesmontalvo3
requested changes
Feb 11, 2019
sorry for all the commits
|
Okay...so looks like all the nit-picking is fixed. As for the actual function...is it complete in your opinion? |
|
How about now? I'd like to know if it's going to have any more changes before relooking through code again. Function on the dev server you added it to looks good. |
|
Yes, i’m all done with changes. |
|
The changes I made fix the I am done making edits (again) |
jamesmontalvo3
approved these changes
Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates Extension:Approved Revs version 1.0 or later into Special:Pending Reviews.