Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for envisage APIs #340

Merged
merged 3 commits into from
Oct 26, 2020
Merged

Conversation

aaronayres35
Copy link
Contributor

fixes #302

This PR updates the module docstrings of api modules so that their content is documented.

The PR is currently flagged as WIP as I am not sure the best way to organize the classes etc so that the documentation is more clear (specifically in the main envisage.api module). ATM I have a Interfaces section and an Exceptions section, but I paused because I feel like this approach is not what we want long term. I imagine we would want to break it up into things like Plugins, ExtensionPoints and Services, or maybe have sections for Managers or Registrys. I am not sure, but will update this PR once this is decided on.

Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure exactly why but the built documentation is still empty.

@aaronayres35
Copy link
Contributor Author

I'm not sure exactly why but the built documentation is still empty.

When I built it locally I was seeing it. Very strange, I will investigate

@aaronayres35
Copy link
Contributor Author

I'm not sure exactly why but the built documentation is still empty.

When I built it locally I was seeing it. Very strange, I will investigate

I can't seem to reproduce. @kitchoi if you have the time would you be able to try building the docs and lmk if the api modules are populated?

@kitchoi
Copy link
Contributor

kitchoi commented Oct 23, 2020

Yep, I can try that.

@kitchoi
Copy link
Contributor

kitchoi commented Oct 23, 2020

I can also see the populated content for the api modules.
This is what I did:

$ git checkout doc-302-document-apis
$ python etstool.py install --editable
$ python etstool.py docs

Then open docs/build/index.html for the main page, and navigate to the corresponding api modules...
e.g.
Screenshot 2020-10-23 at 15 54 26

@rahulporuri rahulporuri changed the title [WIP] Add documentation for envisage APIs Add documentation for envisage APIs Oct 26, 2020
Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rahulporuri
Copy link
Contributor

I'm not sure exactly why but the built documentation is still empty.

Sorry about that. I always forget to install the package in editable mode.

Co-authored-by: Poruri Sai Rahul <[email protected]>
@aaronayres35 aaronayres35 merged commit 8245931 into master Oct 26, 2020
@aaronayres35 aaronayres35 deleted the doc-302-document-apis branch October 26, 2020 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for envisage.api is empty
3 participants