-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for envisage APIs #340
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure exactly why but the built documentation is still empty.
When I built it locally I was seeing it. Very strange, I will investigate |
I can't seem to reproduce. @kitchoi if you have the time would you be able to try building the docs and lmk if the api modules are populated? |
Yep, I can try that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sorry about that. I always forget to install the package in editable mode. |
Co-authored-by: Poruri Sai Rahul <[email protected]>
fixes #302
This PR updates the module docstrings of api modules so that their content is documented.
The PR is currently flagged as WIP as I am not sure the best way to organize the classes etc so that the documentation is more clear (specifically in the main
envisage.api
module). ATM I have aInterfaces
section and anExceptions
section, but I paused because I feel like this approach is not what we want long term. I imagine we would want to break it up into things likePlugins
,ExtensionPoints
andServices
, or maybe have sections forManagers
orRegistry
s. I am not sure, but will update this PR once this is decided on.