Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant returns throughout the codebase #393

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

mdickinson
Copy link
Member

This PR removes the redundant returns scattered through the codebase. We've cleaned up many of these on an as-and-when basis (e.g., when making other changes to a given file), but there were plenty left over.

Automated tooling (a static AST analysis) was used to find these redundant returns; they were fixed manually.

Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdickinson mdickinson merged commit 20a4114 into master Jan 5, 2021
@mdickinson mdickinson deleted the fix-martin-returns branch January 5, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants