Deprecate environmental plugin managers #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corranwebster
approved these changes
Mar 17, 2023
|
I'm going to update the warning messages to remove the mentions of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates the following three plugin managers:
Each of these uses a rather ad-hoc method to find and load plugins. There are other maintainability issues, too, for example with building eggs, or with the managers modifying global state that doesn't belong to them (like
sys.path, for example).The recommended way to retrieve plugins from an environment going forward is to install plugin-carrying packages into site-packages and have those packages advertise their plugins through entry points (which are now an official part of core Python, not just setuptools). Other application-specific ad-hoc mechanisms should be implemented by the application itself rather than by this library.
The current warning messages are based on the assumption that #532 will go in; if not, we'll need to drop references to the
EntryPointPluginManager.Related discussion: #521
See also #532
Closes #541