Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up legacy examples #557

Merged
merged 10 commits into from
Mar 23, 2023
Merged

Clean up legacy examples #557

merged 10 commits into from
Mar 23, 2023

Conversation

mdickinson
Copy link
Member

@mdickinson mdickinson commented Mar 23, 2023

[Includes commits from #556]

This PR cleans up our legacy examples, either deleting them or making them work:

  • Makes the AcmeLab workbench-based example work again, primarily by fixing Python 2 relative imports.
  • Removes two egg-based demos: AcmeLabUsingEggs and MOTD_Using_Eggs.
  • Removes the Lorenz demo, which uses parts of Chaco that no longer exist (ChacoPlotItem)
  • Fixes flake8 issues (mostly unused imports and missing copyright headers) in remaining examples
  • Removes the examples directory exclusion from the .flake8 configuration file

Closes #381
Closes #361
Closes #329

@mdickinson mdickinson changed the title Cleanup legacy examples Clean up legacy examples Mar 23, 2023
@mdickinson mdickinson mentioned this pull request Mar 23, 2023
@mdickinson
Copy link
Member Author

Updated to remove an outdated doc page related to MOTD_UsingEggs (that Sphinx was already complaining about because it wasn't reachable).

@mdickinson mdickinson merged commit 5c55463 into main Mar 23, 2023
@mdickinson mdickinson deleted the cleanup-legacy-examples branch March 23, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants