Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test on Python 3.7 and 3.8, and update classifiers for Python 3.8 #8

Merged
merged 5 commits into from
Feb 3, 2020
Merged

Test on Python 3.7 and 3.8, and update classifiers for Python 3.8 #8

merged 5 commits into from
Feb 3, 2020

Conversation

mdickinson
Copy link
Member

@mdickinson mdickinson commented Jan 20, 2020 •
edited
Loading

Run Travis CI tests on Python 3.7 and 3.8, and update classifiers to make it clear 3.8 is supported.

EDIT: Also changes the way that the NumPy version is selected. See discussion in #10.

Closes #9.

@mdickinson
Copy link
Member Author

NumPy issues on 3.5 and 3.7 on Linux (but fine on 3.6 and 3.8). Permissions issues on Windows.

@mdickinson
Copy link
Member Author

The NumPy versions differ for the various Travis CI builds; looks like we have a problem with NumPy 1.15.4.

  • Python 2.7: NumPy 1.16.2
  • Python 3.5: NumPy 1.15.4
  • Python 3.6: NumPy 1.16.2
  • Python 3.7: NumPy 1.15.4
  • Python 3.8: NumPy 1.17.2

@mdickinson
Copy link
Member Author

PR is on hold until appveyor permissions can be fixed (waiting on internal IT request).

@mdickinson mdickinson changed the title Test on Python 3.7 and 3.8, and update classifiers for Python 3.8 [On hold] Test on Python 3.7 and 3.8, and update classifiers for Python 3.8 Jan 20, 2020
This was referenced Jan 20, 2020
Closed
Closed
@mdickinson mdickinson closed this Feb 3, 2020
@mdickinson mdickinson reopened this Feb 3, 2020
@mdickinson mdickinson closed this Feb 3, 2020
@mdickinson mdickinson reopened this Feb 3, 2020
@mdickinson mdickinson closed this Feb 3, 2020
@mdickinson mdickinson reopened this Feb 3, 2020
@mdickinson mdickinson changed the title [On hold] Test on Python 3.7 and 3.8, and update classifiers for Python 3.8 Test on Python 3.7 and 3.8, and update classifiers for Python 3.8 Feb 3, 2020
@mdickinson
Copy link
Member Author

Appveyor is now working, and passing.

@mdickinson
Copy link
Member Author

@rahulporuri Would you be willing to review? (Not at all urgent.)

@mdickinson mdickinson merged commit cdb90e7 into master Feb 3, 2020
@mdickinson mdickinson deleted the support-python-38 branch February 3, 2020 15:43
@mdickinson mdickinson mentioned this pull request Oct 7, 2020
Closed
@mdickinson mdickinson mentioned this pull request Jun 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulporuri rahulporuri rahulporuri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ImportError failure with NumPy 1.15.4
2 participants
@mdickinson @rahulporuri