Skip to content

Commit

Permalink
Work around test failures.
Browse files Browse the repository at this point in the history
- Thanks to @larsoner for help with the macos-latest issue.
- The test failure seems some strange issue with recent PySide6 versions
  all the way back to 6.6.2.
  • Loading branch information
prabhuramachandran committed May 22, 2024
1 parent d5b9551 commit 758862e
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/run-mayavi-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
tests:
strategy:
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
os: [ubuntu-latest, windows-latest, macos-13]
python-version: ['3.8']
qt-api: ['pyqt5']
vtk: ['vtk<9.3']
Expand All @@ -37,7 +37,7 @@ jobs:
vtk: 'vtk<9.3'
- python-version: '3.10'
qt-api: 'pyside6'
os: macos-latest
os: macos-13
vtk: 'vtk<9.3'
fail-fast: false
defaults:
Expand Down
5 changes: 5 additions & 0 deletions mayavi/tests/test_garbage_collection.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,15 @@
class TestMayaviGarbageCollection(TestGarbageCollection):
""" See: tvtk.tests.common.TestGarbageCollection
"""

@unittest.skipIf(ETSConfig.toolkit == 'null',
'Test should not run when the ETS toolkit is null')
def test_mlab_scene_model_with_gui(self):
""" Tests if MlabSceneModel with GUI can be garbage collected."""
from pyface.qt import qt_api
if qt_api == 'pyside6':
raise unittest.SkipTest('Test fails with PySide6.')

class MlabApp(HasTraits):

# The scene model.
Expand Down

0 comments on commit 758862e

Please sign in to comment.