Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.8.2 #1301

Merged
merged 3 commits into from
May 23, 2024
Merged

Release 4.8.2 #1301

merged 3 commits into from
May 23, 2024

Conversation

prabhuramachandran
Copy link
Member

No description provided.

@prabhuramachandran prabhuramachandran merged commit 1d094b6 into master May 23, 2024
11 checks passed
@larsoner larsoner deleted the release-4.8.2 branch May 26, 2024 22:08
@larsoner
Copy link
Collaborator

@prabhuramachandran did you happen to cythonize array_ext.pyx before release using Cython 3.0.10, and with NumPy 2.0 installed? I got a diff when I did. And without it, compiling against 2.0 fails. See the patch I had to add here:

conda-forge/mayavi-feedstock#80

Might be worth cutting a 4.8.3 since the NumPy 2.0 release is imminent 😞

@prabhuramachandran
Copy link
Member Author

Oh no, I did not do that. Should I clobber the existing array_ext.c with this new version then? I can push a release in a few days I hope. Are there any other issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants