Move repository into sat #110
Conversation
This Repository class is a simplified version of the one in enstaller. It also improves on the enstaller one by supporting deterministic iteration: for a given set of packages, iterating over the repository will always yield the packages in the same order, independently of how packages were added.
| self._name_to_packages[package_metadata.name].append(package_metadata) | ||
| # Fixme: this should not be that costly as long as we don't have | ||
| # many versions for a given package. | ||
| self._name_to_packages[package_metadata.name].sort( |
There was a problem hiding this comment.
What is the argument against making PackageMetadata orderable and using insort here too?
There was a problem hiding this comment.
Looking at the definition of PackageMetadata, the sorting would occur on (name, version, dependencies, python_tag), which I think would be acceptable here.
There was a problem hiding this comment.
I think I benchmarked that for small sequences, sorting every time is faster than calling insort, but let me check again since a lot of the code changed since.
There was a problem hiding this comment.
Ok, so there is no measurable speed change in my limited test, but to work properly, it requires a change in PackageMetadata (as they are not orderable ATM). Since I will rewrite PackageMetadata to be in SAT, I would suggest to make that change then
|
One question, otherwise LGTM |
|
|
||
| class Repository(object): | ||
| """ | ||
| A Repository is a set of package, and knows about which package it |
We also return a tuple instead of a list in find_packages, so that the output is 'naturally' immutable.
|
LGTM |
This PR implements a simplified
Repositoryclass to replace the enstaller one in simplesat:PackageMetadatasubclassfind_package*andupdatemethods.This is the penultimate PR to remove the dependency on enstaller. The last one will implement a leaner
PackageMetadataclass.@johntyree