-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and standardize Python versions #1569
Conversation
From actions/setup-python#249, it looks as though we may actually be able to use plain old 3.10 now. I'll let the CI for the above run to completion, then try updating. |
That's exciting: we've got an actual test failure (segfault) on 3.10:
This smells like a bug in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one small comment
@@ -11,7 +11,7 @@ jobs: | |||
strategy: | |||
matrix: | |||
os: [ubuntu-latest, windows-latest] | |||
python-version: [3.6, 3.9, 3.10-dev] | |||
python-version: [3.6, 3.8, 3.10.0-rc.2] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we're running the full testsuite with all supported pythons - which is why we can just ignore 3.7 and 3.9 here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point; we should update this too, I think. (To include all Python versions.)
Dismissing because of the CI failure on Python 3.10 rc
The python version of 3.10 was being interpreted as a (floating-point) number, equal to 3.1. The fix is to add quotes to make it clear it's a string. Since it's fundamentally wrong to treat versions as numbers rather than strings, I've added those quotes to all python versions. |
Converting to draft while we work through the various failures. |
@rahulporuri Okay, I think this is looking okay now. Apologies for the false starts. |
Sigh. Spoke too soon. There's still a macOS failure. |
This has to do with a bad NumPy build on Python 3.10. It's not clear why NumPy is being built at all - that is, why we're not simply using the wheel. I'll investigate. |
NumPy 1.22 supports Python 3.10, but isn't released yet. NumPy 1.21 has preliminary support and test wheels for Linux, but doesn't officially support 3.10. We should just exclude NumPy from the test requirements on Python 3.10 for now. |
Now this is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR updates the CI workflows (other than the PyPI upload workflow - see #1567 for that) to standardize the Python versions: