Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Agent #23

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

anhhuyalex
Copy link

No description provided.

Copy link
Contributor

@cswinter cswinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Some high level comments:

  • Let's move all the _validate_x methods out of the MultiValidatingEnv into standalone helper methods and use them in ValidatingEnv so the code is not duplicated
  • I wonder if some deduplication is possible for the ValidatingEnv as well? Since it already only expects a VecEnv, most of the code should just work the same way, except for any additional MultiEnvList specific metrics we might want to export.
  • For testing, you can add a simple multiagent environment in env/examples and add a test case to tests/test_environment.py similar to test_env_list. Maybe a generic implementation of 2 player game with simultaneous actions and payoff matrix? That would also be useful for later checking that training is working correctly and we find the correct solution to classic game theory problems.
  • If you want to go the extra mile, you could add some documentation for the multi agent environment (see the docs dir). You can build the docs by running poetry run make html and look at them at localhost:8000 by starting an http server poetry run python -m http.server 8000 in the docs/build/html dir.

@cswinter
Copy link
Contributor

@anhhuyalex would love to get this merged! are you still interested in completing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants