-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HERMA 10003/4345 labels #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general, thanks!
Can you rebase and squash the commits together? Should be ready then.
Sure. |
5a602ad
to
dfcb5a8
Compare
b6a8edd
to
8213198
Compare
Add setup for HERMA No. 10003 (former article No. 4345). Measurements are taken from the API called by the HERMA label assistant (https://backend2.herma-eao.de/eao/article/bf388863/10003). doc: Update usage with herma10003 option for format flag doc: add HERMA 10003 to supported sheets
8213198
to
f6c5ee6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
f6c5ee6
to
4fa854c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleaned up the rebase history, should be fine now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This got a bit confusing
Hi,
this PR adds the Label Info for HERMA 10003 (formerly called HERMA 4345) labels.
These are 35.6 x 16.8 mm labels (80 per A4 sheet) I use for my paperless-ngx workflow.
Measurements are taken from the API that works in the background of their online label assistant.
As this prints fine, and as recommended in a similar PR #12 (review), I also felt free to add this to the Supported Sheets sections.
I also updated the usage section in the docs with the added format.
Thank you for your great project!