Benchmark the CCTV RSA vector #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #66 +/- ##
=======================================
Coverage 99.44% 99.44%
=======================================
Files 10 10
Lines 1449 1449
=======================================
Hits 1441 1441
Misses 8 8 ☔ View full report in Codecov by Sentry. |
fjarri
reviewed
Jan 7, 2025
fjarri
reviewed
Jan 7, 2025
fjarri
reviewed
Jan 7, 2025
fjarri
reviewed
Jan 7, 2025
fjarri
reviewed
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a recent blogpost, the golang stdlib maintainers described a neat benchmarking trick where they construct a statistically average sequence of primality candidates, hitting the various stages of their primality testing code in a mathematically sane way.
They published a test vector over at the CCTV repo and this PR adds benchmarks for that TV, allowing fair (?) comparisons between different implementations.