forked from alsotang/meteor
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs cn 0.7.1.2 #21
Open
booxood
wants to merge
2,534
commits into
enumerable:docs-cn
Choose a base branch
from
booxood:docs-cn-0.7.1.2
base: docs-cn
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Docs cn 0.7.1.2 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tool no longer uses it. Simplify webapp_server to do a dumb check for a flag instead of using optimist. ctl-helper still uses optimist; ideally it should use our parser from main.js instead. Also, remove a debugging "|| true" that was causing "LISTENING" to be output even without --keepalive. I am not actually planning to rebuild the dev bundle just to drop optimist.
(This was not a tool-refactoring change.)
This is consistent with old password prompts (see meteor#1600), and also makes it so that everyone who calls `doInteractivePasswordLogin` is using the same stream as `doInteractivePasswordLogin`.
Per [RFC 5849](http://tools.ietf.org/html/rfc5849), the POST request for the access token should not include a body, but instead include the verifier as part of the "Authorization: OAuth" header. The current code is broken for authentication against servers which verify the body of the POST request (in particular, Fitbit has recently switched to this verification).
Should have updated the test with 38734b9.
We'll probably revisit this when we build out the package server, but this is a relatively safe start that removes our GitHub-specific check. Fixes meteor#1686. (This doesn't technically fix the case in that bug but if you know what you're doing you can add the SHA yourself.)
Add some helpers like `withAccountsConnection` for running functions that need a connection to the accounts server.
- Exit with failure if proxy starts to listen. Previously, we got stuck inside ProxyRunner.start(), and since we weren't waiting on any IO we'd exit 0! (The existence of a yielded fiber is not sufficient to block Node exit.) - Don't print various bits of startup text if we are stopped midway. - Stop main Runner immediately if proxy or mongo runners invoke onFailure, rather than waiting for wait to be called and return. - Ensure that a few Futures don't get return called on them multiple times. - Ensure we don't try to call close() on the proxy's TCP server if it failed to listen in the first place.
Not sure if this is possible in practice (the listening callback gets invoked via nextTick, which is usually before the event loop).
Not fixing this, as there is no regression from devel.
Also some comment/style tweaks
Previously, if stop() was invoked during the 1-second restart timeout, it would not stop running.
Conflicts: docs/.meteor/release
Otherwise can crash mongod! Wed Feb 26 11:09:32.829 [conn499] logs.tmp-test-logs-10833_meteor_com Assertion failure str::startsWith(ns, "local.oplog.") src/mongo/db/repl_block.cpp 261 0x10b9245ab 0x10b8fb64c 0x10b816015 0x10b5b2d06 0x10b714ce6 0x10b6bf354 0x10b6c398b 0x10b4dd9e2 0x10b917699 0x10b957055 0x7fff948637a2 0x7fff948501e1 I20140226-11:09:32.831(-8) (satellite.js:296) process 85850 for job tmp-test-logs-10833.meteor.com null exited with 1 0 mongod 0x000000010b9245ab _ZN5mongo15printStackTraceERSo + 43 1 mongod 0x000000010b8fb64c _ZN5mongo12verifyFailedEPKcS1_j + 284 2 mongod 0x000000010b816015 _ZN5mongo19updateSlaveLocationERNS_5CurOpEPKcNS_6OpTimeE + 2405 3 mongod 0x000000010b5b2d06 _ZN5mongo12ClientCursor19updateSlaveLocationERNS_5CurOpE + 52 4 mongod 0x000000010b714ce6 _ZN5mongo14processGetMoreEPKcixRNS_5CurOpEiRbPb + 534 5 mongod 0x000000010b6bf354 _ZN5mongo15receivedGetMoreERNS_10DbResponseERNS_7MessageERNS_5CurOpE + 1492 6 mongod 0x000000010b6c398b _ZN5mongo16assembleResponseERNS_7MessageERNS_10DbResponseERKNS_11HostAndPortE + 4939 7 mongod 0x000000010b4dd9e2 _ZN5mongo16MyMessageHandler7processERNS_7MessageEPNS_21AbstractMessagingPortEPNS_9LastErrorE + 198 8 mongod 0x000000010b917699 _ZN5mongo17PortMessageServer17handleIncomingMsgEPv + 1657 9 mongod 0x000000010b957055 thread_proxy + 229 10 libsystem_c.dylib 0x00007fff948637a2 _pthread_start + 327 11 libsystem_c.dylib 0x00007fff948501e1 thread_start + 13
Conflicts: History.md docs/.meteor/release docs/lib/release-override.js examples/leaderboard/.meteor/release examples/parties/.meteor/release examples/todos/.meteor/release examples/wordplay/.meteor/release scripts/admin/banner.txt
…cs-cn-0.7.1.2 Conflicts: README.md docs/client/api.html docs/client/concepts.html docs/client/introduction.html Modify: 1.更新 meteor repo 到 4555d2c(Meteor release-0.7.1.2) 2.修改concepts.html:private目录新增的说明,文件加载顺序,package部分说明
这个改动实在太大了,我可能近期要好好看一下才能 merge。 |
有些人家新加的章节,你这里是没有跟进的对吗? |
@alsotang 对,前面那部分有几个新增的地方还没有翻译 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify:
1.更新 meteor repo 到 4555d2c(Meteor release-0.7.1.2)
2.修改concepts.html:private目录新增的说明,文件加载顺序,package部分说明