Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logs - make the visable in our app #13

Merged
merged 2 commits into from
Jul 6, 2023
Merged

Fix logs - make the visable in our app #13

merged 2 commits into from
Jul 6, 2023

Conversation

razbensimon
Copy link

show them in the stderr

@razbensimon razbensimon requested review from a team July 6, 2023 13:51
@razbensimon razbensimon self-assigned this Jul 6, 2023
@@ -1,5 +1,9 @@
#!/usr/bin/env bash

function info() {
echo -e "\033[0;32m[INFO] ${1}\033[0;39m" >&2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing it won't be red right?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the error

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be green
image

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I validated that it's green? Which is also a weird color for info. shouldn't it be white/gray

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. NVM it's super minor.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@razbensimon razbensimon merged commit aafd4f2 into master Jul 6, 2023
@razbensimon razbensimon deleted the fix-err-logs branch July 6, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant