extracting more pages and versions #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RLRabinowitz
approved these changes
Mar 17, 2022
| @@ -1,5 +1,6 @@ | |||
| #!/usr/bin/env bash | |||
| set -e | |||
| pages=4 | |||
There was a problem hiding this comment.
Any reason this is specifically 4? Wouldn't this mean we'd need to change this value in the future?
There was a problem hiding this comment.
we might. for now it works, and it is the maximal number of pages. tried finding the max page, needs working with regexes, over the headers of the request. burnt too much time on it. defaulted to magic number for now, willing to open a ticket for later fixing it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.