fetching more version based on the amount of pages we can fetch #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix local fallback
eranelbaz
reviewed
Apr 6, 2022
libexec/tgenv-list-remote
Outdated
|
|
||
| # the response header (--head) contains a link to the last page, contains the last page number and the "last" keyword to help identify | ||
| page_curl=$(curl -s --tlsv1.2 --head "$link_release") | ||
| only_relevant_part=$(echo "$page_curl" | grep -o -E "&page=[0-9]+>; rel=\"last") |
There was a problem hiding this comment.
only_relevant_part relevant to who?
please find better name
|
default is 4 because as for these lines were written that's how many pages there are. In case for any reason the format of the response header changes, I wished to still retrieve extra pages, not just the first, so 4 seems like a reasonable default @eranelbaz |
eranelbaz
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the original implementation fetched only the first page. it means newer versions push older ones from the list of results. Therefor this fork TGENV needed a hotfix for older versions. the solution wan’t as pretty as it should have been - we used magic number for the number of pages.
As a solution added functionality for fetching the amount of pages and then fetching those pages too