Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delete version folder on curl fail #8

Merged
merged 3 commits into from
Jun 1, 2022

Conversation

tomer-landesman
Copy link

@tomer-landesman tomer-landesman commented Jun 1, 2022

The Issue
for some reason, command tgenv-install sometimes fails on curl command, resulting in Tarball download failed.
although the operation failed, the terragrunt folder inside versions is still created, therefore causing a bug when trying to retry the tgenv-install command.

The Fix
added a check after CURL to check exit status (assuming it was not 0 when failed)
if its not 0 - remove terragrunt folder so that we can retry the command again.

@tomer-landesman tomer-landesman added bug Something isn't working work in progress labels Jun 1, 2022
Copy link

@sagilaufer1992 sagilaufer1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch. just edit the comment and merge

Co-authored-by: sagilaufer1992 <[email protected]>
@tomer-landesman tomer-landesman merged commit 39d19d0 into master Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants