Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning in Swift 4.1.50 #56

Merged
merged 1 commit into from
Jun 20, 2018
Merged

Fix warning in Swift 4.1.50 #56

merged 1 commit into from
Jun 20, 2018

Conversation

keith
Copy link
Contributor

@keith keith commented Jun 20, 2018

Since implicitly unwrapped optionals got a bit of a makeover, this IUO
caused a warning with Swift 4.1.50 (Xcode 10). This change is backwards
compatible with Swift 4.1.2 (Xcode 9.4)

Since implicitly unwrapped optionals got a bit of a makeover, this IUO
caused a warning with Swift 4.1.50 (Xcode 10). This change is backwards
compatible with Swift 4.1.2 (Xcode 9.4)
Copy link
Contributor

@fangpenlin fangpenlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 @keith thanks for fixing this!

@fangpenlin fangpenlin merged commit 671965f into envoy:master Jun 20, 2018
@keith
Copy link
Contributor Author

keith commented Jun 20, 2018

Thanks!

@fangpenlin
Copy link
Contributor

Let me make a release quickly

@keith
Copy link
Contributor Author

keith commented Jun 20, 2018

No worries for us! Just at some point

@fangpenlin
Copy link
Contributor

@keith done 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants