Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implements aws oidc backendSecurityPolicy API #306

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 30 additions & 9 deletions internal/controller/backend_security_policy.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,23 +19,44 @@ import (
//
// This handles the BackendSecurityPolicy resource and sends it to the config sink so that it can modify configuration.
type backendSecurityPolicyController struct {
client client.Client
kube kubernetes.Interface
logger logr.Logger
eventChan chan ConfigSinkEvent
client client.Client
kube kubernetes.Interface
logger logr.Logger
eventChan chan ConfigSinkEvent
reconcileAll bool
}

func newBackendSecurityPolicyController(client client.Client, kube kubernetes.Interface, logger logr.Logger, ch chan ConfigSinkEvent) *backendSecurityPolicyController {
return &backendSecurityPolicyController{
client: client,
kube: kube,
logger: logger,
eventChan: ch,
client: client,
kube: kube,
logger: logger,
eventChan: ch,
reconcileAll: true,
}
}

// Reconcile implements the [reconcile.TypedReconciler] for [aigv1a1.BackendSecurityPolicy].
func (b backendSecurityPolicyController) Reconcile(ctx context.Context, req ctrl.Request) (res ctrl.Result, err error) {
func (b *backendSecurityPolicyController) Reconcile(ctx context.Context, req ctrl.Request) (res ctrl.Result, err error) {
if b.reconcileAll {
var backendSecPolicyList aigv1a1.BackendSecurityPolicyList
err = b.client.List(ctx, &backendSecPolicyList)
if err != nil {
b.logger.Error(err, "failed to trigger refresh for existing backendSecPolicy resources")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
b.logger.Error(err, "failed to trigger refresh for existing backendSecPolicy resources")
b.logger.Error(err, "failed to list existing backendSecPolicy resources")

} else {
refreshTime := time.Now().String()
for _, backendSecurityPolicy := range backendSecPolicyList.Items {
aabchoo marked this conversation as resolved.
Show resolved Hide resolved
if isBackendSecurityPolicyAuthOIDC(backendSecurityPolicy.Spec) {
backendSecurityPolicy.Annotations["refresh"] = refreshTime
}
err = b.client.Update(ctx, &backendSecurityPolicy)
if err != nil {
b.logger.Error(err, "failed to trigger refresh for existing backendSecPolicy resource", "name", backendSecurityPolicy.Name)
}
}
aabchoo marked this conversation as resolved.
Show resolved Hide resolved
b.reconcileAll = false
}
}
var backendSecurityPolicy aigv1a1.BackendSecurityPolicy
if err = b.client.Get(ctx, req.NamespacedName, &backendSecurityPolicy); err != nil {
if errors.IsNotFound(err) {
Expand Down
3 changes: 2 additions & 1 deletion internal/controller/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,9 @@ func backendSecurityPolicyIndexFunc(o client.Object) []string {
awsCreds := backendSecurityPolicy.Spec.AWSCredentials
if awsCreds.CredentialsFile != nil {
key = getSecretNameAndNamespace(awsCreds.CredentialsFile.SecretRef, backendSecurityPolicy.Namespace)
} else if awsCreds.OIDCExchangeToken != nil {
key = fmt.Sprintf("%s.%s", backendSecurityPolicy.Name, backendSecurityPolicy.Namespace)
}
// TODO: OIDC.
}
return []string{key}
}
Expand Down
Loading