Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that admin mutations should be POST #602

Merged
merged 1 commit into from
Apr 4, 2018

Conversation

jmarantz
Copy link
Contributor

@jmarantz jmarantz commented Apr 3, 2018

Signed-off-by: Joshua Marantz [email protected]

envoyproxy/envoy#2971 adds warning-checks that mutations should be POSTed. This documents that status. In a future PR, mutations will fail if they are not POSTs.

See envoyproxy/envoy#2763 for more detail.

Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you fix DCO?

@jmarantz
Copy link
Contributor Author

jmarantz commented Apr 3, 2018

I can try but it seems I am not good at DCO.

@jmarantz jmarantz force-pushed the admin-post-mutation-doc branch from 14d73b3 to 2c41495 Compare April 4, 2018 13:42
@jmarantz
Copy link
Contributor Author

jmarantz commented Apr 4, 2018

Woo-hoo! Re-learned how to resolve DCO:

  git log --oneline|head
  git reset --soft <HASH OF MY COMMIT>
  git commit --amend
  git push --no-verify --force

@htuch htuch merged commit b9ab706 into envoyproxy:master Apr 4, 2018
@jmarantz jmarantz deleted the admin-post-mutation-doc branch April 4, 2018 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants