This repository has been archived by the owner on Dec 16, 2020. It is now read-only.
Add a bool return from onConfigure and add onValidateConfiguration(). #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
envoyproxy#183 Signed-off-by: John Plevyak <[email protected]>
Signed-off-by: John Plevyak <[email protected]>
|
FYI: as a sideeffect of me improving my dev environment to auto-format files, the API file is now being formatted in Envoy style. If this makes the review too difficult tell me and I'll do that separately. |
…alidate Signed-off-by: John Plevyak <[email protected]>
Signed-off-by: John Plevyak <[email protected]>
…alidate Signed-off-by: John Plevyak <[email protected]>
Signed-off-by: John Plevyak <[email protected]>
|
Ping |
PiotrSikora
reviewed
Sep 17, 2019
Signed-off-by: John Plevyak <[email protected]>
…alidate Signed-off-by: John Plevyak <[email protected]>
PiotrSikora
approved these changes
Sep 18, 2019
| @@ -3,9 +3,10 @@ | |||
|
|
|||
| #include "proxy_wasm_intrinsics.h" | |||
|
|
|||
| extern "C" EMSCRIPTEN_KEEPALIVE void proxy_onConfigure(uint32_t, int bad, char* configuration, | |||
| int size) { | |||
| extern "C" EMSCRIPTEN_KEEPALIVE uint32_t proxy_onConfigure(uint32_t, int bad, char* configuration, | |||
There was a problem hiding this comment.
Nit: you could have left it as void proxy_onConfigure(uint32_t, char* configuration, int size), since it's supposed to be bad signature anyway.
There was a problem hiding this comment.
Yes, but does it reverts the approval if I change anything... ?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#183
Signed-off-by: John Plevyak [email protected]
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]