core: buffer body for retries (#511)

Description: set stream options to buffer stream body for retries. Risk Level: med - the client now buffers stream body for retries. Testing: local - lyft and example apps. Signed-off-by: Jose Nino <[email protected]> Signed-off-by: JP Simard <[email protected]>
envoyproxy · Nov 29, 2022 · 7b27e5b · 7b27e5b
1 parent 6c8eaf6
commit 7b27e5b
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/mobile/library/common/http/dispatcher.cc b/mobile/library/common/http/dispatcher.cc
@@ -148,7 +148,14 @@ envoy_status_t Dispatcher::startStream(envoy_stream_t new_stream_handle,
         std::make_unique<DirectStreamCallbacks>(new_stream_handle, bridge_callbacks, *this);
 
     AsyncClient& async_client = getClient();
-    AsyncClient::Stream* underlying_stream = async_client.start(*callbacks, {});
+    // Note: currently all streams are set to buffer body data for retries.
+    // This is done as an assumption that almost all client calls are retriable,
+    // and the penalty for those that are not is minimal.
+    // The stream options could be exposed
+    // (like in: https://github.com/lyft/envoy-mobile/pull/456/) in the future,
+    // if the library needs the added configuration flexiblity.
+    AsyncClient::Stream* underlying_stream =
+        async_client.start(*callbacks, AsyncClient::StreamOptions().setBufferBodyForRetry(true));
 
     if (!underlying_stream) {
       // TODO: this callback might fire before the startStream function returns.