Review: add warning and fix style

Signed-off-by: Takeshi Yoneda <[email protected]>
envoyproxy · Feb 25, 2021 · fda8ed6 · fda8ed6
1 parent 2077a4e
commit fda8ed6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/api/envoy/extensions/wasm/v3/wasm.proto b/api/envoy/extensions/wasm/v3/wasm.proto
@@ -95,9 +95,10 @@ message VmConfig {
   bool nack_on_code_cache_miss = 6;
 
   // Specifies environment variables to be injected to this VM which will be available through
-  // WASI's `environ_get` and `environ_get_sizes` system calls. Note that these functions are mostly implicitly
+  // WASI's ``environ_get`` and ``environ_get_sizes`` system calls. Note that these functions are mostly implicitly
   // called in your language's standard library, so you do not need to call them directly and you can access to env
   // vars just like when you do on native platforms.
+  // Warning: Envoy rejects the configuration if there's conflict of key space.
   EnvironmentVariables environment_variables = 7;
 }
 

diff --git a/generated_api_shadow/envoy/extensions/wasm/v3/wasm.proto b/generated_api_shadow/envoy/extensions/wasm/v3/wasm.proto