Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envoy.reloadable_features.enable_dns_cache_circuit_breakers deprecation #14642

Closed
mattklein123 opened this issue Jan 11, 2021 · 0 comments · Fixed by #14683
Closed

envoy.reloadable_features.enable_dns_cache_circuit_breakers deprecation #14642

mattklein123 opened this issue Jan 11, 2021 · 0 comments · Fixed by #14683
Assignees
@Shikugawa
Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt
Milestone
1.18.0

Comments

@mattklein123
Copy link
Member

Your change #11028 (dynamic_forward_proxy: DNS Cache circuit breaker) introduced a runtime guarded feature. It has been 6 months since the new code has been exercised by default, so it's time to remove the old code path. This issue tracks source code cleanup so we don't forget.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shikugawa Shikugawa

Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt
Projects
None yet
Milestone
1.18.0
2 participants
@mattklein123 @Shikugawa