dynamic_forward_proxy: DNS Cache circuit breaker #11028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shikugawa <[email protected]>
Signed-off-by: shikugawa <[email protected]>
mattklein123
requested changes
May 1, 2020
There was a problem hiding this comment.
Flushing out a few API comments. Note that this will require documentation and release notes. We also need to figure out how to gracefully handle the existing use case. I think potentially if the new config is not set we should use the cluster circuit breaker for some period of time in the existing HTTP code. Need to discuss. Thank you!
/wait
Signed-off-by: shikugawa <[email protected]>
Signed-off-by: shikugawa <[email protected]>
Signed-off-by: shikugawa <[email protected]>
mattklein123
reviewed
May 4, 2020
api/envoy/extensions/common/dynamic_forward_proxy/v3/dns_cache.proto
Outdated
Show resolved
Hide resolved
Signed-off-by: shikugawa <[email protected]>
Signed-off-by: shikugawa <[email protected]>
Signed-off-by: shikugawa <[email protected]>
mattklein123
requested changes
May 7, 2020
api/envoy/config/common/dynamic_forward_proxy/v2alpha/dns_cache.proto
Outdated
Show resolved
Hide resolved
Signed-off-by: shikugawa <[email protected]>
mattklein123
requested changes
May 13, 2020
source/extensions/common/dynamic_forward_proxy/dns_cache_impl.cc
Outdated
Show resolved
Hide resolved
source/extensions/common/dynamic_forward_proxy/dns_cache_resource_manager.h
Outdated
Show resolved
Hide resolved
source/extensions/common/dynamic_forward_proxy/dns_cache_resource_manager.h
Outdated
Show resolved
Hide resolved
Signed-off-by: Shikugawa <[email protected]>
mattklein123
requested changes
Jun 26, 2020
source/extensions/common/dynamic_forward_proxy/dns_cache_impl.cc
Outdated
Show resolved
Hide resolved
source/extensions/filters/http/dynamic_forward_proxy/proxy_filter.cc
Outdated
Show resolved
Hide resolved
Signed-off-by: Shikugawa <[email protected]>
mattklein123
requested changes
Jun 29, 2020
Signed-off-by: Shikugawa <[email protected]>
|
@Shikugawa can you merge master? it conflicts with security patches. |
Signed-off-by: Shikugawa <[email protected]>
Signed-off-by: Shikugawa <[email protected]>
Signed-off-by: Shikugawa <[email protected]>
Signed-off-by: Shikugawa <[email protected]>
|
@lizan @mattklein123 Windows CI is failing. This seems that there is potential problems in Windows building. |
…-circuit-breaker Signed-off-by: Shikugawa <[email protected]>
Signed-off-by: Shikugawa <[email protected]>
mattklein123
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: shikugawa [email protected]
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message: In the current implementation of the DNS cache, circuit breaker is derived from cluster config. It seems unnatural. In this PR, I implemented the DNS cache specific circuit breaker by adding resource manager to that.
Additional Description:
Risk Level: Mid
Testing: Unit / Integration
Docs Changes: Required
Release Notes: Required
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]