-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependency: gcovr 3.4 #2739
Comments
Realistically I'm not sure how soon coverage is really going to change. @moderation I would just do the upgrade if you feel like it. Thank you! |
Bazel team are working on fixing coverage to support lcov atm, so there is reason to suspect we might get lcov in the medium term. |
FYI I'm updating gcovr to 3.4 in this PR #7391 (4.1 is out but it would require quite a few more changes) but I didn't revisit this comment, so that's something we could do after merging |
We're no longer using gcovr. |
* add stackdriver stub param * dedup envoy grpc proto build code * clean up
dependency: Investigate updating to gcovr 3.4
Description: gcovr 3.4 was recently released (release notes). There are work arounds in the code for gcovr 3.3 bugs that are outlined at
envoy/ci/do_ci.sh
Lines 127 to 135 in 43df022
Question is should we investigate 3.4 or stay on 3.3 until gcovr is replaced which is covered in #1000
The text was updated successfully, but these errors were encountered: