Supports GRPC streaming based on Asyn HTTP2 client. #381
Comments
|
Is that going to support generated grpc code or not? |
|
It's not for generated grpc code. It's for generic calls.
…On Thu, Jan 26, 2017 at 7:22 PM Lizan Zhou ***@***.***> wrote:
Is that going to support generated grpc code or not?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#381 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AT1vm3bB1EbvUw7eWF4rtGQIqTyzXTxBks5rWWMSgaJpZM4LvVXv>
.
|
|
@fengli79 I know it's a question for the gRPC folks, but is there any chance of getting it eventually working with gRPC compiled code similar to how we use the deprecated generic RPC proto stuff here: https://github.com/lyft/envoy/blob/master/source/common/grpc/rpc_channel_impl.h? That would be really neat to get working in the future. |
|
We don't have plan to do that yet, however I would vote for yes if it's
highly desired by community.
…On Fri, Jan 27, 2017 at 9:41 PM Matt Klein ***@***.***> wrote:
@fengli79 <https://github.com/fengli79> I know it's a question for the
gRPC folks, but is there any chance of getting it eventually working with
gRPC compiled code similar to how we use the deprecated generic RPC proto
stuff here:
https://github.com/lyft/envoy/blob/master/source/common/grpc/rpc_channel_impl.h?
That would be really neat to get working in the future.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#381 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AT1vmzGO6jJINvh5PTgt7hspABWZPxNyks5rWtT2gaJpZM4LvVXv>
.
|
|
@fengli79 I started this branch to do zero copy for proto encode/decode: I don't have time to finish this right now, but if you find it useful for the streaming gRPC stuff feel free to build on it. |
|
Per offsite meeting, we are going to integrate the full gRPC stack into Envoy to make outbound calls. It doesn't sound like a tremendous amount of work. I'm going to won't fix this for now and open a new issue on that. |
|
OK, please assign it to me once you create it. |
* Rename HTTPControll to MixerControl. * use unordered_map.
Updates our Swift example app to use the Envoy Mobile direct interfaces rather than using `URLSession` and Envoy as a listener. Similar change to envoyproxy/envoy-mobile#349 which updated the Swift example app. Notes: - Changed all Objective-C demo app sources to `.m`, as they don't contain C/++ and thus don't need to be `.mm` - Had to make some unfortunate changes to `Client.swift` and move the extension function to be implemented directly by the `Envoy` class, since extensions aren't allowed on Swift protocols that are visible to Objective-C. This temporarily breaks the `ClientTests.swift` file (not being run on CI), and I will open a PR after this lands to refactor/fix as necessary Signed-off-by: Michael Rebello <[email protected]> Signed-off-by: JP Simard <[email protected]>
Updates our Swift example app to use the Envoy Mobile direct interfaces rather than using `URLSession` and Envoy as a listener. Similar change to envoyproxy/envoy-mobile#349 which updated the Swift example app. Notes: - Changed all Objective-C demo app sources to `.m`, as they don't contain C/++ and thus don't need to be `.mm` - Had to make some unfortunate changes to `Client.swift` and move the extension function to be implemented directly by the `Envoy` class, since extensions aren't allowed on Swift protocols that are visible to Objective-C. This temporarily breaks the `ClientTests.swift` file (not being run on CI), and I will open a PR after this lands to refactor/fix as necessary Signed-off-by: Michael Rebello <[email protected]> Signed-off-by: JP Simard <[email protected]>
Pull request #353 is going to support async stream HTTP2 client in envoy.
After that, I'm going to implement the GRPC client on top of it to enable GRPC streaming calls.
The text was updated successfully, but these errors were encountered: