Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider turning on cluster update merging by default #4018

Closed
mattklein123 opened this issue Aug 1, 2018 · 1 comment
Closed

Consider turning on cluster update merging by default #4018

mattklein123 opened this issue Aug 1, 2018 · 1 comment
Labels
enhancement Feature requests. Not bugs or questions. help wanted Needs help!

Comments

@mattklein123
Copy link
Member

See #3941

I would suggest we wait at least one release until we get some bake time on this, then maybe make it default to 1s or something?

cc @rgs1
@mattklein123 mattklein123 added enhancement Feature requests. Not bugs or questions. help wanted Needs help! labels Aug 1, 2018
@rgs1
Copy link
Member

rgs1 commented Aug 1, 2018

Yeah, sounds good once we've gained more confidence. I think subsecond updates are probably rarely needed so 1s default sounds reasonable.

rgs1 pushed a commit to rgs1/envoy that referenced this issue Nov 10, 2018
Turn on cluster update merging by default
a1dba97 
We've been using this in production for over 3 months now and it's
been very useful to prevent CPU spikes when we get a stream of
updates.

This enables update merging every 1s.

Fixes envoyproxy#4018.

Signed-off-by: Raul Gutierrez Segales <[email protected]>
@rgs1 rgs1 mentioned this issue Nov 10, 2018
Merged
mattklein123 pushed a commit that referenced this issue Nov 12, 2018
@rgs1 @mattklein123
Turn on cluster update merging by default (#5009)
fad993e 
We've been using this in production for over 3 months now and it's
been very useful to prevent CPU spikes when we get a stream of
updates.

This enables update merging every 1s.

Fixes #4018.

Signed-off-by: Raul Gutierrez Segales <[email protected]>
fredlas pushed a commit to fredlas/envoy that referenced this issue Mar 5, 2019
@rgs1 @fredlas
Turn on cluster update merging by default (envoyproxy#5009)
e0fc47b 
We've been using this in production for over 3 months now and it's
been very useful to prevent CPU spikes when we get a stream of
updates.

This enables update merging every 1s.

Fixes envoyproxy#4018.

Signed-off-by: Raul Gutierrez Segales <[email protected]>
Signed-off-by: Fred Douglas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature requests. Not bugs or questions. help wanted Needs help!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rgs1 @mattklein123