Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: add 'explicit' to Stats::DynamicName ctor, so that it is called out explicitly and greppable #12643

Merged
merged 2 commits into from
Aug 14, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/common/stats/utility.h
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class DynamicName : public absl::string_view {
// This is intentionally left as an implicit conversion from string_view to
// make call-sites easier to read, e.g.
// Utility::counterFromElements(*scope, {DynamicName("a"), DynamicName("b")});
DynamicName(absl::string_view str) : absl::string_view(str) {}
explicit DynamicName(absl::string_view str) : absl::string_view(str) {}
};

/**
Expand Down