Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listener: add envoy internal listener #12838

Closed
wants to merge 115 commits into from
Closed

Conversation

lambdai
Copy link
Contributor

@lambdai lambdai commented Aug 27, 2020

Commit Message:
The internal listener at connection handler setting register itself on certain internal address.
This PR demonstrate how an internal listener register on the dispatcher, and the flow of
dispatcher could create a internal connection pair when the cluster wants to connect to
the internal listener.

Also rename the Network::ListenerImpl to Network::TcpListenerImpl

Additional Description:
The internal connection is not implemented yet. The next PR will provide the implementation
of user space connection.
Extracted from https://github.com/lambdai/envoy-dai/tree/wiphostconn
on top of #12837 as how internal server address is used

Part of #11725

Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]

@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.

🐱

Caused by: #12838 was opened by lambdai.

see: more, trace.

Signed-off-by: Yuchen Dai <[email protected]>
/**
* Wrapper for an active internal listener owned by this handler.
*/
class ActiveInternalListener : public Network::InternalListenerCallbacks,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New internal listener type

@alyssawilk
Copy link
Contributor

Want to ping back on this one once CI is happy, or let me know why CI failures are to be expected?

@htuch
Copy link
Member

htuch commented Sep 14, 2020

CC @penguingao re: layering, composition of filters and internal loopback.

Signed-off-by: Yuchen Dai <[email protected]>
Signed-off-by: Yuchen Dai <[email protected]>
Signed-off-by: Yuchen Dai <[email protected]>
Signed-off-by: Yuchen Dai <[email protected]>
Signed-off-by: Yuchen Dai <[email protected]>
Signed-off-by: Yuchen Dai <[email protected]>
Signed-off-by: Yuchen Dai <[email protected]>
Signed-off-by: Yuchen Dai <[email protected]>
Signed-off-by: Yuchen Dai <[email protected]>
Signed-off-by: Yuchen Dai <[email protected]>
Signed-off-by: Yuchen Dai <[email protected]>
Signed-off-by: Yuchen Dai <[email protected]>
Signed-off-by: Yuchen Dai <[email protected]>
Signed-off-by: Yuchen Dai <[email protected]>
Signed-off-by: Yuchen Dai <[email protected]>
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Dec 11, 2020
@github-actions
Copy link

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot closed this Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants