filter: http: jwt: implement matching for HTTP CONNECT #13064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove an existing TODO and implement the matcher, which mirrors the behavior of the HTTP router, using the `RouteMatch` configuration to determine whether the matcher should run for a given request. This change allows JWT-based authentication for HTTP CONNECT requests. Clean up a TODO in `uber_per_filter.cc` and remove some obsolete cleanup code. Signed-off-by: Nick Travers <[email protected]>
|
cc: @alyssawilk |
qiwzhang
approved these changes
Sep 11, 2020
mattklein123
approved these changes
Sep 11, 2020
There was a problem hiding this comment.
It kills me that we have this stuff duplicated all over the place, but thanks for cleaning this up. cc @snowp @yangminzhu for another place to unify.
lhluo
pushed a commit
to lhluo/envoy
that referenced
this pull request
Sep 11, 2020
…code * upstream/master: lint: add more linters for using absl:: over std:: (envoyproxy#13043) udpa: filesystem list collection support for inline entries. (envoyproxy#13028) filter: http: jwt: implement matching for HTTP CONNECT (envoyproxy#13064) [fuzz] split http filter logic into a fuzzing class (envoyproxy#13016) xds: allow empty delta update (envoyproxy#12699) CacheFilter: parses the allowed_vary_headers from the cache config. (envoyproxy#12928) router: extend HTTP CONNECT route matching criteria (envoyproxy#13056) docs: clarify use of Extended CONNECT for h/2 (envoyproxy#13051) build: shellcheck tools/ (envoyproxy#13007) [fuzz] Refactored Health Checker Impl Tests (envoyproxy#13017) Signed-off-by: Lihao Luo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove an existing TODO and implement the matcher, which mirrors the
behavior of the HTTP router, using the
RouteMatchconfiguration todetermine whether the matcher should run for a given request.
This change allows JWT-based authentication for HTTP CONNECT requests.
Clean up a TODO in
uber_per_filter.ccand remove some obsolete cleanupcode.
Additional Description: This is a follow-on from #13056.
Risk Level: Medium (minor extension to an existing feature).
Testing: Unit test cases added for matching.
Docs Changes: n/a
Release Notes: n/a