backport to 1.14: Renew certificates used in unit and integration tests. #14503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Pakulski <[email protected]>
|
Is there potential for us using the same cert contents in the various branches? It seems like at least some of the cert names referenced in this PR also exist in master, 1.16, 1.15, and 1.13 |
|
Good point. Not sure what are expiration dates of certificates on master. If they are going to expire within a year, it may affect branches 1.13-1.16 if they are simply backported. I simply regenerated certs individually for each branch and they are going to be good until end of life for each stable release. |
antoniovicente
approved these changes
Jan 6, 2021
|
We can work out a plan going forward somewhere else, approving this since we should unblock release branch tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Some certificates used in unit and integration tests expired in middle of December.
This PR contains renewed certs.
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]