Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wasm: add api for configuring environment variable in VmConfig #15136
wasm: add api for configuring environment variable in VmConfig #15136
Changes from 2 commits
c389247
2077a4e
fda8ed6
8bab14a
194471b
1fec667
dd00186
065cbe8
851bd2e
0306a2f
8b602a2
cb9b1df
8fa9a02
dd9568c
d1eb946
e8795f5
824f0e7
a917095
5c1f0f0
fc931d4
d6268a8
041286f
22ee914
2f1e10b
b4e5d56
3ed2309
435f69a
3d6dc03
78ac3f8
4e4ccf7
84a4f5c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we want some notion of env vars elsewhere in xDS as well, so we might want to factor this message to base types. @markdroth thoughts?
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.