Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm: update V8 to v9.7.106.17. #19244

Merged
merged 2 commits into from
Dec 17, 2021
Merged

wasm: update V8 to v9.7.106.17. #19244

merged 2 commits into from
Dec 17, 2021

Conversation

PiotrSikora
Copy link
Contributor

@PiotrSikora PiotrSikora commented Dec 10, 2021

While there, fix build with MSan (broken in #18621).

Signed-off-by: Piotr Sikora [email protected]

@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #19244 was opened by PiotrSikora.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Dec 10, 2021
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @mattklein123

🐱

Caused by: #19244 was opened by PiotrSikora.

see: more, trace.

@PiotrSikora PiotrSikora marked this pull request as ready for review December 11, 2021 01:26
@moderation
Copy link
Contributor

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Dec 11, 2021
Broken in envoyproxy#18621.

Signed-off-by: Piotr Sikora <[email protected]>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Dec 13, 2021
@moderation
Copy link
Contributor

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Dec 13, 2021
@XuehaiPan
Copy link

This dependency update may also fix building with Python 3.10. See Homebrew/homebrew-core#90921.

@PiotrSikora
Copy link
Contributor Author

@phlax could you merge this?

Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@phlax phlax merged commit 15f79ad into envoyproxy:main Dec 17, 2021
joshperry pushed a commit to joshperry/envoy that referenced this pull request Feb 13, 2022
Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Josh Perry <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants