xds: add config for wrr_locality and round_robin LB policy extensions #19517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark D. Roth <[email protected]>
Signed-off-by: Mark D. Roth <[email protected]>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
htuch
reviewed
Jan 13, 2022
api/envoy/extensions/load_balancing_policies/wrr_locality/v3/wrr_locality.proto
Show resolved
Hide resolved
htuch
reviewed
Jan 14, 2022
api/envoy/extensions/load_balancing_policies/round_robin/v3/round_robin.proto
Show resolved
Hide resolved
lizan
approved these changes
Jan 14, 2022
joshperry
pushed a commit
to joshperry/envoy
that referenced
this pull request
Feb 13, 2022
…envoyproxy#19517) This PR adds two new LB policy extension configurations, to be used in gRPC via the new load_balancing_policy field: * round_robin: This allows configuring the built-in ROUND_ROBIN LB policy via the new extension-based API. * wrr_locality: This is an extension config for a new policy that does ROUND_ROBIN-style locality picking and then delegates to a child LB policy extension to pick the endpoint within the locality. This will allow users to plugin their own custom endpoint-picking logic without having to reimplement the locality-picking logic. This is a small step toward moving away from the legacy lb_policy enum. Completing that migration will require work in Envoy to create extension configs for all built-in LB policies and register those extensions. Risk Level: Low Testing: N/A Docs Changes: Included in PR Release Notes: N/A Platform Specific Features: N/A Signed-off-by: Mark D. Roth <[email protected]> Signed-off-by: Josh Perry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mark D. Roth [email protected]
Commit Message: xds: add config for wrr_locality and round_robin LB policy extensions
Additional Description: This PR adds two new LB policy extension configurations, to be used in gRPC via the new
load_balancing_policyfield:round_robin: This allows configuring the built-in ROUND_ROBIN LB policy via the new extension-based API.wrr_locality: This is an extension config for a new policy that does ROUND_ROBIN-style locality picking and then delegates to a child LB policy extension to pick the endpoint within the locality. This will allow users to plugin their own custom endpoint-picking logic without having to reimplement the locality-picking logic.This is a small step toward moving away from the legacy
lb_policyenum. Completing that migration will require work in Envoy to create extension configs for all built-in LB policies and register those extensions.Risk Level: Low
Testing: N/A
Docs Changes: Included in PR
Release Notes: N/A
Platform Specific Features: N/A
CC @htuch @temawi @ejona86 @dfawley @pianiststickman