make total weight optional

[zirain]

Signed-off-by: hejianpeng [email protected]

Commit Message: make WeightedCluster.TotalWeight optional
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] #21845
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

[repokitteh-read-only]

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy[\w/]*/(v1alpha\d?|v1|v2alpha\d?|v2))|(api/envoy/type/(matcher/)?\w+.proto).
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @markdroth
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #21892 was opened by zirain.

see: more, trace.

[wbpcode]

/retest

[repokitteh-read-only]

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #21892 (comment) was created by @wbpcode.

see: more, trace.

[wrowe]

/assign-from envoyproxy/envoy-maintainers

[repokitteh-read-only]

envoyproxy/envoy-maintainers assignee is @mattklein123

🐱

Caused by: a #21892 (comment) was created by @wrowe.

see: more, trace.

[mattklein123]

LGTM with small comment, thanks.

/wait

[wrowe]

/wait

on release notes requested

[markdroth]

Is there actually any reason why the total_weight field is useful? It seems like it just pushes a sanity check down to the client that could just as easily be done on the server. Maybe we should just deprecate that field?

[mattklein123]

Is there actually any reason why the total_weight field is useful? It seems like it just pushes a sanity check down to the client that could just as easily be done on the server. Maybe we should just deprecate that field?

It's been a long time, but historically I think the reason this field existed is due to the common mistake of not adjusting weights in tandem and then users not understand why things were not adding up correctly. One could argue this could be checked by something higher layer. I don't fully strongly about it at this point.

[mattklein123]

Thanks!

[zirain]

CI is blocked?