listener: enable UdpListenerWorkerRouter to support multiple addresses #21940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: He Jie Xu <[email protected]>
Signed-off-by: He Jie Xu <[email protected]>
Signed-off-by: He Jie Xu <[email protected]>
Signed-off-by: He Jie Xu <[email protected]>
Signed-off-by: He Jie Xu <[email protected]>
soulxu
changed the title
|
/assign @mattklein123 |
Signed-off-by: He Jie Xu <[email protected]>
Signed-off-by: He Jie Xu <[email protected]>
mattklein123
requested changes
Jun 29, 2022
source/server/listener_impl.h
Outdated
| @@ -494,6 +499,7 @@ class ListenerImpl final : public Network::ListenerConfig, | |||
|
|
|||
| Quic::QuicStatNames& quic_stat_names_; | |||
| MissingListenerConfigStats missing_listener_config_stats_; | |||
| uint32_t concurrency_; | |||
There was a problem hiding this comment.
nit: const. As an aside it would be nice to not have to store this in every listener, but there probably isn't a great way to do that without passing through all server options so I guess it's ok.
There was a problem hiding this comment.
I think I can get that from the server instance directly, let me try, also thanks point this out, it indeed better to not pass through it, and it doesn't feel like something the ListenerImpl need to hold one.
Signed-off-by: He Jie Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: listener: enable UdpWorkerRouter to support multiple addresses
Additional Description:
This PR enable the
ListenerImplto createUdpListenerWorkerRouterfor each address. And pass the correctUdpListenerWorkerRouterto theActiveUdpListener.Risk Level: high
Testing: unittest
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a
Part of #11184