-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples: Cleanups/fixes for docker deps and builds #21962
Conversation
d3be17b
to
32d790e
Compare
9b6bb56
to
7269ab7
Compare
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
96c6c45
to
6a35fa7
Compare
ad305fb
to
0113c94
Compare
Signed-off-by: Ryan Northey <[email protected]>
/retest |
Retrying Azure Pipelines: |
/lgtm deps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, I have one question to resolve first.
What is the philosophy on updating these newly pinned dependencies as they bit rot? Is this something that needs to be documented?
/lgtm deps |
The same question as before, though, before we merge, is there a logic to keeping the pinned dependencies from bit-rotting, @phlax? |
Similar answer to before - there is this one is a pretty straight refactoring - it shouldnt change how things work - but as you rightly point out it changes the standards for including deps amongst other things - im defo happy to follow up if that is ok |
That's great, please create an issue pointing to these two (and other relevant) PR's to note the WIP/TODO? |
Hi! Came here from #20915 which is supposedly fixed with this here thread. But I still get |
hi @Moonsilence can you post the hash of your local repo when the error occurs |
can you post the exact commands you are running when this happens also, maybe docker/docker-compose versions |
@phlax Sure, appreciated! I am trying to run the Sandbox "Front Proxy" from the latest official Envoy documentation: The very first command is: My version of docker-compose: v2.6.1 Error Messages:
|
ok - i see some of the docs have the instruction of and i think should work with little difference in outcome ill update the docs to reflect the better command can you confirm this command works ok @Moonsilence ? |
hmm, actually im realising that doesnt pull the images if they exist already and that this was added for a reason (albeit an imperfect one) ill test again further - i was convinced i fixed this at least for sme of the examples, but now im wondering... |
ok - so it seems my fix didnt work 8( - altho it was needed for other reasons (and i think partially resolved the issue) what does seem to work is doing the following... $ docker-compose pull
$ docker-compose up --build -d
ill update the docs with these instructions |
@phlax Thanks, I have the "Front Proxy" example up and running, using your commands from previous post.
... gives me a warning:
...but then...
... finally builds that image. Then your next command
spins up the deployment. Thanks!! |
hmm - thats odd this is the outpuf of pull for me ..front-proxy$ docker-compose pull
Pulling flask_service ... done
Pulling front-envoy ... done
Pulling service1 ... done
Pulling service2 ... done
WARNING: Some service image(s) must be built from source by running:
docker-compose build flask_service
..front-proxy$ echo "$?"
0 $ docker --version
Docker version 20.10.10, build b485636
$ docker-compose --version
docker-compose version 1.29.2, build unknown
ill update the docs on the basis that it works mostly (i have tested in other similar env - debian <> ubuntu) not sure why you are getting an error still - but v2.6.1 doesnt seem to exist for docker-compose |
...for docker-compose i see that is the version for this is currently untested im afraid |
pr with updated docs instructions is here #22132 |
docker-compose
bin path configurableSigned-off-by: Ryan Northey [email protected]
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]