multiple addresses listener: remove legacy interface #22381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: He Jie Xu <[email protected]>
Signed-off-by: He Jie Xu <[email protected]>
soulxu
requested review from
ggreenway,
adisuissa,
htuch and
alyssawilk
as code owners
Signed-off-by: He Jie Xu <[email protected]>
|
/assign @mattklein123 also |
|
also cannot be assigned to this issue. |
|
/assign @mattklein123 |
|
@adisuissa you're first pass for this one. PTAL |
|
actually looks like adi is out today so @KBaichoo can you do a pass today? |
|
@alyssawilk this should probably be stamped by a senior maintainer. |
alyssawilk
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: multiple addresses listener: remove the legacy interface
Additional Description:
Since the multiple addresses listener is implemented, all the code moves to use the new multiple socket factories interface, then those old single socket factory interfaces can be removed now.
Risk Level: low
Testing: unittest
Docs Changes: n/a
Release Notes: n/a
Fixes #11184